<html>
<head><meta charset="utf-8"><title>Meetings 2021-07-14 · t-libs/meetings · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/index.html">t-libs/meetings</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html">Meetings 2021-07-14</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="245995016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/245995016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#245995016">(Jul 14 2021 at 17:48)</a>:</h4>
<p>Libs Meeting Agenda: <a href="https://hackmd.io/@rust-libs/HJpbQs3a_">https://hackmd.io/@rust-libs/HJpbQs3a_</a><br>
Libs API Meeting Agenda: <a href="https://hackmd.io/@rust-libs/B1sAMs2TO">https://hackmd.io/@rust-libs/B1sAMs2TO</a></p>



<a name="245995216"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/245995216" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#245995216">(Jul 14 2021 at 17:49)</a>:</h4>
<p>Let me do the Mara thing</p>



<a name="245995273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/245995273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#245995273">(Jul 14 2021 at 17:50)</a>:</h4>
<p>Hey <span class="user-group-mention" data-user-group-id="4493">@T-libs</span> <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span>  We have a meeting at <time datetime="2021-07-07T18:00:00Z">2021-07-07T20:00:00+02:00</time> aka in 10 minutes</p>



<a name="246014514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246014514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246014514">(Jul 14 2021 at 20:19)</a>:</h4>
<p>about <a href="https://github.com/rust-lang/rust/issues/53823">#53823</a> earlier there was the question if the binary_search would have to be reverted to the old impl if we picked solution 2 (specialized x86 asm!) to which my answer was yes. But I forgot about <code>partition_point</code>. We can fix partition point this way without waiting for LLVM changes since it doesn't need or want the O(1)-for-exact-matches implementation.</p>
<p>So the we could do a partial fix on the libs side and point users to try partition_point if that fits their use-case.</p>



<a name="246014648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246014648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246014648">(Jul 14 2021 at 20:20)</a>:</h4>
<p>But probably not worth it anyway.</p>



<a name="246025693"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246025693" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246025693">(Jul 14 2021 at 21:43)</a>:</h4>
<p>I wanted to make sure that the backport nomination for <a href="https://github.com/rust-lang/rust/issues/85953">#85953</a> gets looked at. It looks like the automation only picks up things that are still open?</p>



<a name="246026329"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246026329" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246026329">(Jul 14 2021 at 21:49)</a>:</h4>
<p>I think only the release team looks at beta-nominated tags. The libs team only looks at I-nominated</p>



<a name="246026571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246026571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246026571">(Jul 14 2021 at 21:51)</a>:</h4>
<p>There's a section for backports in the agenda?</p>



<a name="246026700"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246026700" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246026700">(Jul 14 2021 at 21:52)</a>:</h4>
<p><a href="https://hackmd.io/@rust-libs/HJpbQs3a_#Backports">https://hackmd.io/@rust-libs/HJpbQs3a_#Backports</a></p>



<a name="246026747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246026747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246026747">(Jul 14 2021 at 21:53)</a>:</h4>
<p>good point, idk where I go that idea then.</p>



<a name="246032844"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246032844" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246032844">(Jul 14 2021 at 23:00)</a>:</h4>
<p>looks like the issue query only checks <code>is:open</code>, but yes we should check <em>all</em> backport nominations<br>
<a href="https://github.com/rust-lang/libs-team/blob/9fda0c2cce47ca137b3d04210e09532eaab5d5d5/tools/agenda-generator/src/generator.rs#L338">https://github.com/rust-lang/libs-team/blob/9fda0c2cce47ca137b3d04210e09532eaab5d5d5/tools/agenda-generator/src/generator.rs#L338</a></p>



<a name="246037091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037091">(Jul 15 2021 at 00:00)</a>:</h4>
<p>I don't think that's actually the query.</p>



<a name="246037111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037111">(Jul 15 2021 at 00:00)</a>:</h4>
<p>Just the link that shows up in the assembeld agenda.</p>



<a name="246037122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037122">(Jul 15 2021 at 00:01)</a>:</h4>
<p>This is the query: <a href="https://github.com/rust-lang/libs-team/blob/9fda0c2cce47ca137b3d04210e09532eaab5d5d5/tools/agenda-generator/src/generator.rs#L328">https://github.com/rust-lang/libs-team/blob/9fda0c2cce47ca137b3d04210e09532eaab5d5d5/tools/agenda-generator/src/generator.rs#L328</a></p>



<a name="246037214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037214">(Jul 15 2021 at 00:02)</a>:</h4>
<p>As I understand it, the final query URL looks something like <code>https://api.github.com/repos/rust-lang/rust/issues?labels=beta-nominated,t-libs</code></p>



<a name="246037292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037292">(Jul 15 2021 at 00:03)</a>:</h4>
<p>The problem is that github adds an implicit "state=open" paramater, <a href="https://docs.github.com/en/rest/reference/issues">as documented here</a>.</p>



<a name="246037374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246037374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246037374">(Jul 15 2021 at 00:04)</a>:</h4>
<p>What we'd really like is for the final query URL to be <code>https://api.github.com/repos/rust-lang/rust/issues?labels=beta-nominated,t-libs&amp;state=all</code>, and similarly for the other backport related cases.</p>



<a name="246038998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246038998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246038998">(Jul 15 2021 at 00:29)</a>:</h4>
<p>clearly, I'm not familiar with this code :)</p>



<a name="246039040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039040">(Jul 15 2021 at 00:30)</a>:</h4>
<p>care to open a PR?</p>



<a name="246039351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039351">(Jul 15 2021 at 00:35)</a>:</h4>
<p>I'm not either! I just went on a slightly deeper delve.</p>



<a name="246039468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039468">(Jul 15 2021 at 00:37)</a>:</h4>
<p>I'm looking at it.</p>



<a name="246039489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039489">(Jul 15 2021 at 00:38)</a>:</h4>
<p>Hrmm.</p>



<a name="246039664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039664">(Jul 15 2021 at 00:41)</a>:</h4>
<p>The tricky bit is that we probably want to include closed <code>stable/beta-nominated</code> issues, but not closed "stable/beta-accepted` issues.</p>



<a name="246039678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039678">(Jul 15 2021 at 00:41)</a>:</h4>
<p>The simplest thing to do is probably to break backports into seperate nominated and accepted subsections.</p>



<a name="246039879"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039879" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039879">(Jul 15 2021 at 00:45)</a>:</h4>
<p>I don't know why we need to look at accepted at all, actually</p>



<a name="246039924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039924">(Jul 15 2021 at 00:46)</a>:</h4>
<p>once it's nominated+accepted, the release team will see it for backport</p>



<a name="246039938"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039938" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039938">(Jul 15 2021 at 00:46)</a>:</h4>
<p><a href="https://forge.rust-lang.org/release/backporting.html">https://forge.rust-lang.org/release/backporting.html</a></p>



<a name="246039964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246039964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> cuviper <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246039964">(Jul 15 2021 at 00:47)</a>:</h4>
<p>though note that the release-team's query also only looks at the pr once it's closed -- we want it done on master first</p>



<a name="246042183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246042183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246042183">(Jul 15 2021 at 01:36)</a>:</h4>
<p>Okay, if it's really totally fine to not list <code>stable/beta-accepted</code> issues,  then I've got it implemented.</p>



<a name="246042210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246042210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246042210">(Jul 15 2021 at 01:36)</a>:</h4>
<p>I'm worried I'll cause someone to miss something they need to see though...</p>



<a name="246042733"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246042733" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246042733">(Jul 15 2021 at 01:46)</a>:</h4>
<p>Ahh, I see.</p>



<a name="246042739"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246042739" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246042739">(Jul 15 2021 at 01:46)</a>:</h4>
<p>No, that's not going to work.</p>



<a name="246042746"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/259402-t-libs/meetings/topic/Meetings%202021-07-14/near/246042746" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> inquisitivecrystal <a href="https://rust-lang.github.io/zulip_archive/stream/259402-t-libs/meetings/topic/Meetings.202021-07-14.html#246042746">(Jul 15 2021 at 01:46)</a>:</h4>
<p>I need to fix something.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>